[alsa-devel] [PATCH 01/19] ASoC: upd9976: Add Renesas uPD9976 codec driver

Takashi Iwai tiwai at suse.de
Wed May 4 17:07:24 CEST 2011


At Wed, 4 May 2011 15:34:51 +0100,
Mark Brown wrote:
> 
> On Wed, May 04, 2011 at 09:44:58PM +0800, Lu Guanqun wrote:
> 
> > +static const struct snd_kcontrol_new upd9976_snd_controls[] = {
> > +	SOC_DOUBLE_R_TLV("Headphone & Speaker Volume",
> 
> Master Volume would be a better name.

Yes, also in general, try to avoid special letters like "&".


Takashi


More information about the Alsa-devel mailing list