[alsa-devel] [PATCH] ASoC: Add MAX9850 codec driver

Dimitris Papastamos dp at opensource.wolfsonmicro.com
Tue Mar 8 11:21:45 CET 2011


On Tue, Mar 08, 2011 at 01:40:05AM +0900, Seungwhan Youn wrote:
> IMHO, because of MAX9850_* macros are only using inside max9850.c, I
> think that move MAX9850_* macros into max9850.c and remove max9850.h
> header file, is more looks good to me.

It is common practice to have the register definitions / enumerations in
a header file even though they are only used by 1 driver.  However, any
other type declarations or definitions which are not used by multiple
drivers are never put into the header file.

Thanks,
Dimitris


More information about the Alsa-devel mailing list