[alsa-devel] [PATCH] ASoC: Add MAX9850 codec driver

[Seungwhan Youn]

Hi,

> diff --git a/sound/soc/codecs/max9850.h b/sound/soc/codecs/max9850.h
> new file mode 100644
> index 0000000..5268575
> --- /dev/null
> +++ b/sound/soc/codecs/max9850.h
> @@ -0,0 +1,41 @@
> +/*
> + * max9850.h  --  codec driver for max9850
> + *
> + * Copyright (C) 2011 taskit GmbH
> + * Author: Christian Glindkamp <christian.glindkamp at taskit.de>
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + *
> + */
> +
> +#ifndef _MAX9850_H
> +#define _MAX9850_H
> +
> +#define MAX9850_STATUSA                        0x00
> +#define MAX9850_STATUSB                        0x01
> +#define MAX9850_VOLUME                 0x02
> +#define MAX9850_GENERAL_PURPOSE                0x03
> +#define MAX9850_INTERRUPT              0x04
> +#define MAX9850_ENABLE                 0x05
> +#define MAX9850_CLOCK                  0x06
> +#define MAX9850_CHARGE_PUMP            0x07
> +#define MAX9850_LRCLK_MSB              0x08
> +#define MAX9850_LRCLK_LSB              0x09
> +#define MAX9850_DIGITAL_AUDIO          0x0a
> +
> +#define MAX9850_CACHEREGNUM 11
> +
> +/* MAX9850_ENABLE */
> +#define MAX9850_SHDN                   (1<<7)
> +
> +/* MAX9850_DIGITAL_AUDIO */
> +#define MAX9850_MASTER                 (1<<7)
> +#define MAX9850_INV                    (1<<6)
> +#define MAX9850_BCINV                  (1<<5)
> +#define MAX9850_DLY                    (1<<3)
> +#define MAX9850_RTJ                    (1<<2)
> +
> +#endif

IMHO, because of MAX9850_* macros are only using inside max9850.c, I
think that move MAX9850_* macros into max9850.c and remove max9850.h
header file, is more looks good to me.