[alsa-devel] [PATCH] ASoC: Add National Semiconductor LM49352 Audio Codec support
Reddy, MR Swami
MR.Swami.Reddy at nsc.com
Tue Mar 8 05:31:24 CET 2011
Thank you very much for your feedback. I will update the patch as per the comments and submit the update patch for review.
From: Mark Brown [mailto:broonie at opensource.wolfsonmicro.com]
Sent: Monday, March 07, 2011 6:48 PM
To: Reddy, MR Swami
Cc: alsa-devel at alsa-project.org; Liam Girdwood
Subject: Re: [PATCH] ASoC: Add National Semiconductor LM49352 Audio Codec support
On Mon, Mar 07, 2011 at 04:03:55AM -0800, Reddy, MR Swami wrote:
Please fix your MUA to word wrap within paragraphs at less than 80 columns. I've reflowed your mail for legibility. There are some suggestions in Documentation/email-clients.txt.
> Patch for adding National Semiconductor LM49352 Audio Codec (http://www.national.com/ds/LM/LM49352.pdf) support along with Samsung_6410 (i.e. SMDK6410) platform support for LM49352.
> [Tested this patch on SMDK6410 platform with Kernel- 2.6.24 and ALSA version is - 1.0.15].
> Please review and let me know the comments/suggestion on this patch.
You need to follow the standard kernel patch submission process, which is documented in Documentation/SubmittingPatches. In particular you
- Conform to the coding standards in CodingStandards (checkpatch.pl is
helpful for detecting obvious issues). A good high level check is if
your code should visually resemble the rest of the code base.
- Submit your code against the current development kernel version. The
trees will be listed in MAINTAINERS, or -next is a good approximation.
- Send your patch in-line rather than as an attachment.
- Send your patch against the full Linux tree, not a subdirectory of
You should also split your code up into a series of independant patches
- in general each individual driver should be a single patch so your machine and CODEC drivers should be split up. If the machine driver is just for a flying wire system you should remove it, otherwise please also submit the arch/arm parts.
I've not done a detailed review of the code due to the above high level issues.
> And also let me know the forward-porting (to the latest ALSA version APIs) steps/process. Thanks in advance.
You need to figure out a process that works for you. In general inspecting the kernel history is usually very useful for stuff like this, or you could just start from scratch and copy over the active bits of code.
More information about the Alsa-devel