[alsa-devel] [PATCH] [v2] ASoC: cs4270: use the built-in register cache support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 10 20:13:59 CET 2011

On Mon, Jan 10, 2011 at 01:03:26PM -0600, Timur Tabi wrote:

> Well, I'm not sure I agree.  For one thing, the current code doesn't just fail
> to report I/O errors to the callers, it re-interprets an error code as valid
> date and plows right on ahead.

> In addition, there are places where getting a return code would be useful.  I
> call snd_soc_update_bits() in my probe function, so that's a great opportunity
> to tell ASoC that this device is broken and it shouldn't instantiate a sound card.

If you've got the time and enthusiasm to refactor the code to handle
this better feel free to do so; practically speaking it's not a big deal
- I/O rarely fails in production, and when it does fail there's
generally something terribly wrong with the hardware anyway.

More information about the Alsa-devel mailing list