[alsa-devel] [PATCH] [v2] ASoC: cs4270: use the built-in register cache support

Timur Tabi timur at freescale.com
Mon Jan 10 20:03:26 CET 2011

Mark Brown wrote:
> This is all code that's evolved over time, and originally there was no
> readback facility at all (everything came from cache) so there were no
> errors to report in the first place.  Besides, in general there's
> nothing constructive we can do about errors anyway except log them.

Well, I'm not sure I agree.  For one thing, the current code doesn't just fail
to report I/O errors to the callers, it re-interprets an error code as valid
date and plows right on ahead.

In addition, there are places where getting a return code would be useful.  I
call snd_soc_update_bits() in my probe function, so that's a great opportunity
to tell ASoC that this device is broken and it shouldn't instantiate a sound card.

Timur Tabi
Linux kernel developer at Freescale

More information about the Alsa-devel mailing list