[alsa-devel] [PATCH 3/4] ASoC sst: Add mid machine driver

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 3 17:14:58 CET 2011

On Thu, Dec 30, 2010 at 04:43:13PM +0530, Vinod Koul wrote:

> +int create_device(struct platform_device **device, char *name,
> +				void *drv_data)
> +{
> +	int ret_val = 0;

I didn't notice this when I read the driver originally as the file
appears after the actual machine driver: this is is a namespace
violation if nothing else and is not appropraite for doing in a platform
specific subsystem like this; if this is required it should be done in
the device core (and be platform device specific), though I rather
suspect the existing helper functions do the job just fine.

More information about the Alsa-devel mailing list