[alsa-devel] [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter

Lars-Peter Clausen lars at metafoo.de
Fri Apr 29 00:04:04 CEST 2011

On 04/28/2011 11:48 PM, Mark Brown wrote:
> On Thu, Apr 28, 2011 at 11:24:38PM +0200, Lars-Peter Clausen wrote:
>> Hm. I won't argue to death here. I could only repeat what I've said before.
>> But if we keep passing it indirectly we should at least make the struct opaque
>> to the world outside of soc-dapm and move the update pointer from
>> snd_soc_dapm_context to snd_soc_card.
> Moving to the card doesn't seem helpful, while we're currently doing one
> update at once it's not immediately obvious that we want to keep doing
> that indefinitely.

But keeping it in the dapm context would limit us to one update per context
which doesn't seem very sustainable either.
Turning the pointer in the card struct into a list seems like an option though.

dapm_power_widgets works over the whole card, so the updates to be done should
in my opinion be kept on a per card basis as well.

- Lars

More information about the Alsa-devel mailing list