[alsa-devel] [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Apr 28 23:48:18 CEST 2011


On Thu, Apr 28, 2011 at 11:24:38PM +0200, Lars-Peter Clausen wrote:

> Hm. I won't argue to death here. I could only repeat what I've said before.
> But if we keep passing it indirectly we should at least make the struct opaque
> to the world outside of soc-dapm and move the update pointer from
> snd_soc_dapm_context to snd_soc_card.

Moving to the card doesn't seem helpful, while we're currently doing one
update at once it's not immediately obvious that we want to keep doing
that indefinitely.  Like I've said before with the stream events it's
not clear that we should still be using them any more, IIRC there's only
one user which actually cares (tlv320dac33) and that would probably be
perfectly happy with using events on an AIF widget.


More information about the Alsa-devel mailing list