[alsa-devel] [patch v2] ALSA: rawmidi: fix the get next midi device ioctl
error27 at gmail.com
Thu Sep 9 10:46:05 CEST 2010
On Thu, Sep 09, 2010 at 09:44:52AM +0200, Clemens Ladisch wrote:
> Dan Carpenter wrote:
> > If we pass in a device which is higher than SNDRV_RAWMIDI_DEVICES then
> > this function just returns device + 1 which isn't helpful. I've
> > modified it to return -EINVAL instead.
> > Also Smatch complains because the "device + 1" could be an integer
> > overflow. It's harmless,
> It would result in device==INT_MIN, which would make the while loop go
> through 2^31 values before finding the first MIDI device.
Oh crap. You're right. For some reason I got mixed up.
More information about the Alsa-devel