[alsa-devel] [PATCH] wm1133-ev1: fix init for multimachine kernel

Eric Bénard eric at eukrea.com
Fri Oct 22 00:19:31 CEST 2010


Hi Mark,

Le 21/10/2010 23:58, Mark Brown a écrit :
> On Thu, Oct 21, 2010 at 11:35:15PM +0200, Eric Bénard wrote:
>
>> +	if (!machine_is_mx31ads())
>> +		/* return happy. We might run on a totally different machine */
>> +		return 0;
>> +
>
> This is not a sufficient check, we may be running on an mx31ads with a
> different PMIC module.

in which case the current code would also fail ;-)

I don't have such a board but actual code triggers the error log when running 
the kernel on my board so I'm open to your suggestion for a better fix.

Thanks,
Eric


More information about the Alsa-devel mailing list