[alsa-devel] [PATCH] wm1133-ev1: fix init for multimachine kernel

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Oct 22 03:17:57 CEST 2010


On Fri, Oct 22, 2010 at 12:19:31AM +0200, Eric Bénard wrote:
> Le 21/10/2010 23:58, Mark Brown a écrit :
> >On Thu, Oct 21, 2010 at 11:35:15PM +0200, Eric Bénard wrote:

> >This is not a sufficient check, we may be running on an mx31ads with a
> >different PMIC module.

> in which case the current code would also fail ;-)

> I don't have such a board but actual code triggers the error log
> when running the kernel on my board so I'm open to your suggestion
> for a better fix.

Without adding machine fit checks it's always going to fail; machine
type isn't quite enough.  What we should be doing here is using the
multi-component work to allow us to replace soc-audio devices with
devices named for the machine driver (which is all round better anyway).
I'll try to look at this for .38.


More information about the Alsa-devel mailing list