[alsa-devel] [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features

Seungwhan Youn claude.youn at gmail.com
Thu Jul 15 13:33:28 CEST 2010

Hi Mark,

On Thu, Jul 15, 2010 at 6:32 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Jul 15, 2010 at 05:58:47PM +0900, Seungwhan Youn wrote:
>> +     i2s->base = S3C64XX_PA_IISV4;
>> +
> I'd really expect this to be being pulled from the resources for the
> platform device for the DAI rather than hard coded into the driver.  If
> we're going to start reorganising things like this and touching all the
> drivers it'd seem better to go straight to doing that rather than
> introducing this approach.

Does your comment means that 'i2s->base' get base address from the
resources for the platform device using 'platform_get_resources()'?
I'm doing on preparing that issue into another patch already (because
I think this patch is only for Liam's multi-comp, not for that issue).

If the resource should get from platform device, I'll be happy to make
a new one.



More information about the Alsa-devel mailing list