[alsa-devel] [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Jul 15 11:32:21 CEST 2010

On Thu, Jul 15, 2010 at 05:58:47PM +0900, Seungwhan Youn wrote:

> +	i2s->base = S3C64XX_PA_IISV4;
> +

I'd really expect this to be being pulled from the resources for the
platform device for the DAI rather than hard coded into the driver.  If
we're going to start reorganising things like this and touching all the
drivers it'd seem better to go straight to doing that rather than
introducing this approach.

More information about the Alsa-devel mailing list