[alsa-devel] [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface

Peter Ujfalusi peter.ujfalusi at nokia.com
Thu Dec 2 08:06:26 CET 2010


On Wednesday 01 December 2010 13:44:28 ext Mark Brown wrote:
> You didn't mention any pop/click issues in the original patch or the
> discussion following it as far as I remember - in your original patch
> there was nothing motivating doing this

Correct. At that time I did not noticed this problem, and with that HW setup it 
was OK. With different components however the ordering is a problem.
I only had chance/time to look for pop noise recently...

> I think this is a better approach since it solves an actual problem.  We
> may want to consider introducing a new widget type for edge PGAs, though
> I can see that getting overused.

Thanks, I'll send a patch to remove the DAPM things from the tpa driver.
It's a shame, sicne the DAPM things inside of the driver looks quite nice after 
the series ;)

-- 
Péter


More information about the Alsa-devel mailing list