[alsa-devel] [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Dec 1 12:44:28 CET 2010

On Wed, Dec 01, 2010 at 10:07:57AM +0200, Peter Ujfalusi wrote:
> On Wednesday 01 December 2010 08:54:20 Ujfalusi Peter (Nokia-MS/Tampere) wrote:
> > On Tuesday 30 November 2010 16:30:13 ext Mark Brown wrote:

> > > Is there any situation where it would undesirable to do this?  If not
> > > it'd seem better to just make the driver do this always.

> > You mean to not have DAPM widgets/routes in the tpa6130a2 driver, and only
> > have a function, which can be used to turn on/off the amp?
> > The original [1] (first version) of the tpa6130a2 driver only had DAPM_HP
> > widget. It has been changed based on the comments.

You didn't mention any pop/click issues in the original patch or the
discussion following it as far as I remember - in your original patch
there was nothing motivating doing this

> If there's a need I can re-introduce tpa6130a2 provided DAPM_HP widget to reduce 
> duplicated code in machine drivers (when we have enough users for it).
> What do you think?

I think this is a better approach since it solves an actual problem.  We
may want to consider introducing a new widget type for edge PGAs, though
I can see that getting overused.

More information about the Alsa-devel mailing list