[alsa-devel] [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices

Joonyoung Shim jy0922.shim at samsung.com
Fri Aug 13 08:14:51 CEST 2010


Hi,

On 2010-08-13 오후 2:12, Seungwhan Youn wrote:
> Hi Mark,
>
> On Thu, Aug 12, 2010 at 7:02 PM, Mark Brown
> <broonie at opensource.wolfsonmicro.com>  wrote:
>> The IP blocks are all fixed function audio controllers so there's no
>> need to dedupe against other usages and the corresponding arch/arm
>> updates got missed anyway so revert to the original names for the
>> drivers.
>>
>> Signed-off-by: Mark Brown<broonie at opensource.wolfsonmicro.com>
>> ---
>>   sound/soc/s3c24xx/aquila_wm8994.c              |    2 +-
>>   sound/soc/s3c24xx/goni_wm8994.c                |    2 +-
>>   sound/soc/s3c24xx/jive_wm8750.c                |    2 +-
>>   sound/soc/s3c24xx/ln2440sbc_alc650.c           |    2 +-
>>   sound/soc/s3c24xx/neo1973_gta02_wm8753.c       |    2 +-
>>   sound/soc/s3c24xx/neo1973_wm8753.c             |    2 +-
>>   sound/soc/s3c24xx/s3c2412-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/s3c24xx-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_simtec_hermes.c      |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c |    2 +-
>>   sound/soc/s3c24xx/s3c24xx_uda134x.c            |    2 +-
>>   sound/soc/s3c24xx/s3c64xx-i2s-v4.c             |    2 +-
>>   sound/soc/s3c24xx/s3c64xx-i2s.c                |    2 +-
>>   sound/soc/s3c24xx/smartq_wm8987.c              |    2 +-
>>   sound/soc/s3c24xx/smdk64xx_wm8580.c            |    4 ++--
>>   15 files changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>> index 44b06e9..235d197 100644
>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>> @@ -233,7 +233,7 @@ static struct snd_soc_dai_link aquila_dai[] = {
>>   {
>>         .name = "WM8994",
>>         .stream_name = "WM8994 HiFi",
>> -       .cpu_dai_name = "s3c64xx-i2s-v4-dai",
>> +       .cpu_dai_name = "s3c64xx-i2s-v4",
>
> This aquila board also use I2Sv4 from 's3c64xx-i2s-v4.c', so I think
> it'll not work if cpu_dai_name is 's3c64xx-i2s-v4' not
> 's3c64xx-iis-v4'.

It confused me a little to use two names "iis" and "i2s". Can we unify 
to one?


More information about the Alsa-devel mailing list