[alsa-devel] [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices

[Mark Brown]

On 13 Aug 2010, at 07:14, Joonyoung Shim wrote:
> On 2010-08-13 오후 2:12, Seungwhan Youn wrote:
>> On Thu, Aug 12, 2010 at 7:02 PM, Mark Brown

>>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>>> index 44b06e9..235d197 100644
>>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>>> @@ -233,7 +233,7 @@ static struct snd_soc_dai_link aquila_dai[] = {
>>>  {
>>>        .name = "WM8994",
>>>        .stream_name = "WM8994 HiFi",
>>> -       .cpu_dai_name = "s3c64xx-i2s-v4-dai",
>>> +       .cpu_dai_name = "s3c64xx-i2s-v4",

>> This aquila board also use I2Sv4 from 's3c64xx-i2s-v4.c', so I think
>> it'll not work if cpu_dai_name is 's3c64xx-i2s-v4' not
>> 's3c64xx-iis-v4'.

> It confused me a little to use two names "iis" and "i2s". Can we unify to one?

There's no change between -i2s and -iis introduced by this patch, all this patch did was strip the -dai suffix from the names. It looks like this is an error in the Aquilla driver which should be corrected.