[alsa-devel] [PATCH 3/8] McBSP: OMAP3: Add Sidetone feature

Eduardo Valentin eduardo.valentin at nokia.com
Thu Oct 8 15:23:33 CEST 2009

On Thu, Oct 08, 2009 at 03:17:02PM +0200, Mark Brown wrote:
> On Thu, Oct 08, 2009 at 02:58:52PM +0300, Eduardo Valentin wrote:
> > +static const struct attribute *sidetone_attrs[] = {
> > +	&dev_attr_st_enable.attr,
> > +	&dev_attr_st_taps.attr,
> > +	&dev_attr_st_ch0gain.attr,
> > +	&dev_attr_st_ch1gain.attr,
> > +	NULL,
> > +};
> This stuff, particularly the enable, probably wants to be pushed out via
> an ALSA API rather than via random sysfs stuff.  It'd be better to
> publish a control API here and then use that from within ALSA.

I see. The thing is this mcbsp driver is kinda of odd driver.
It is currently a platform driver. And it is supposed to be not
restricted to audio things (even though it is currently used only
by audio). It does not export any alsa interface currently.

So, maybe we should rip off this sysfs things, export
symbols inside kernel and then export to user land somewhere else
from alsa code?

Eduardo Valentin
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the Alsa-devel mailing list