[alsa-devel] [PATCH 3/8] McBSP: OMAP3: Add Sidetone feature

[Mark Brown]

On Thu, Oct 08, 2009 at 02:58:52PM +0300, Eduardo Valentin wrote:

> +static const struct attribute *sidetone_attrs[] = {
> +	&dev_attr_st_enable.attr,
> +	&dev_attr_st_taps.attr,
> +	&dev_attr_st_ch0gain.attr,
> +	&dev_attr_st_ch1gain.attr,
> +	NULL,
> +};

This stuff, particularly the enable, probably wants to be pushed out via
an ALSA API rather than via random sysfs stuff.  It'd be better to
publish a control API here and then use that from within ALSA.
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html