[alsa-devel] [Uclinux-dist-devel] [PATCH 2/2] ASoC: Blackfin AD1836/AD1938 machine drivers: require SPI master

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Oct 7 12:19:27 CEST 2009

On Wed, Oct 07, 2009 at 04:32:06AM -0400, Mike Frysinger wrote:

> hmm, that's certainly true.  if we look at it as "screwed either way",
> then going to a generic bus indirection sounds like it'd only add
> runtime overhead for no real gain ?

I was mostly thinking ifdefs here - we'll always need some bus-specific
stuff in the drivers to register them.  It's not pretty but it meets the
needs of people doing randconfig builds.

We already have as much bus indirection as ASoC needs, and there is
actually already some bus access code sharing there as of 2.6.32 (in
soc-cache.c) but it's optional and always will be since we need to cater
for devices that are parts of MFDs which have device specific register

> in the face of this proposed effort being a ways off, doesnt it make
> sense to still merge the original proposed patch ?

The ifdefery isn't technically hard to do and given your use case where
you don't know which controller is in use it looks like the only way to
go for this.

More information about the Alsa-devel mailing list