[alsa-devel] [Uclinux-dist-devel] [PATCH 2/2] ASoC: Blackfin AD1836/AD1938 machine drivers: require SPI master

Mike Frysinger vapier.adi at gmail.com
Wed Oct 7 10:32:06 CEST 2009

On Tue, Oct 6, 2009 at 18:07, Mark Brown wrote:
> On Tue, Oct 06, 2009 at 05:09:42PM -0400, Mike Frysinger wrote:
>> i dont see how abstracting away the bus such that codec drivers are
>> allowed to build without proper bus support is useful.  the
>> AD1836/AD1938 only work with the SPI bus, so if support for that is
>> disabled, having the driver compiled and installed is pointless.
> Both approaches allow drivers to be built which can't actually be used
> since neither guarantees that there will be a driver for the SPI
> controller.  Either way all we're doing is making sure that the kernel
> will build, the user can still build things so that the audio driver
> won't do anything useful.

hmm, that's certainly true.  if we look at it as "screwed either way",
then going to a generic bus indirection sounds like it'd only add
runtime overhead for no real gain ?

in the face of this proposed effort being a ways off, doesnt it make
sense to still merge the original proposed patch ?

More information about the Alsa-devel mailing list