[alsa-devel] [Uclinux-dist-devel] [PATCH 1/2] ASoC: AD1980/AD73311: make sure to set dev member

[Mike Frysinger]

On Tue, Oct 6, 2009 at 05:42, Mark Brown wrote:
> On Tue, Oct 06, 2009 at 01:51:50AM -0400, Mike Frysinger wrote:
>> The codec driver should initialize snd_soc_codec's dev member to the
>> appropriate device when setting up the device, but these codecs weren't.
>
> No, this is the wrong approach - codec->dev should never be being set to
> the socdev device, it should be being set to the device model device for
> the CODEC (as should the dev members for the DAIs).  For ad73311 this
> means it needs to be converted to use proper device model instantiation,
> see wm8731 for an example of doing this.  ad1980 should be handled by
> generic AC97 code in the core.

meh, this sounds like effort.  i'll trick Cliff/Barry into doing it ;).
-mike