[alsa-devel] [PATCH 1/2] ASoC: AD1980/AD73311: make sure to set dev member
broonie at opensource.wolfsonmicro.com
Tue Oct 6 11:42:33 CEST 2009
On Tue, Oct 06, 2009 at 01:51:50AM -0400, Mike Frysinger wrote:
> The codec driver should initialize snd_soc_codec's dev member to the
> appropriate device when setting up the device, but these codecs weren't.
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
No, this is the wrong approach - codec->dev should never be being set to
the socdev device, it should be being set to the device model device for
the CODEC (as should the dev members for the DAIs). For ad73311 this
means it needs to be converted to use proper device model instantiation,
see wm8731 for an example of doing this. ad1980 should be handled by
generic AC97 code in the core.
More information about the Alsa-devel