[alsa-devel] [Uclinux-dist-devel] [PATCH 2/2] ASoC: Blackfin AD1836/AD1938 machine drivers: require SPI master

Mike Frysinger vapier.adi at gmail.com
Tue Oct 6 11:41:40 CEST 2009


On Tue, Oct 6, 2009 at 05:33, Mark Brown wrote:
> On Tue, Oct 06, 2009 at 01:51:51AM -0400, Mike Frysinger wrote:
>> Since these drivers rely on a SPI master and fail if the SPI functions
>> aren't present, make sure the Kconfig reflects this dependency.
>
> Could you please redo this as a dependency on the relevant SPI
> controller driver?  The audio driver isn't going to work without that
> anyway so it seems more sensible.

there is no dependency on a specific spi bus master implementation.
just like the i2c framework, such a dependency would be against the
whole purpose of having a generic framework in the first place.
fortunately, this is one piece of the Blackfin ASoC drivers done
correctly.  in other words, they should work just fine if hooked up to
a GPIO SPI bus or a SPORT SPI bus or a Blackfin on-chip SPI bus or
......
-mike


More information about the Alsa-devel mailing list