[alsa-devel] [patch 2/2] alsa: s6105 IP camera machine specific ASoC code

Mark Brown broonie at sirena.org.uk
Fri Mar 27 17:39:03 CET 2009

On Fri, Mar 27, 2009 at 05:33:21PM +0100, Daniel Glöckner wrote:
> On 03/26/2009 03:26 PM, Mark Brown wrote:

> > Are you sure you're applying the correct configuration to the correct
> > DAI here - S6105_CODEC_CLOCK is a CPU define, not a CODEC define?

> In this case S6105 was referring to the S6105 reference design. It's a machine
> define at the top of the file.

Hrm, OK.

> >> +static int snd_soc_dapm_set_endpoint(struct snd_soc_codec *codec, char *name,

> > This shouldn't be in a driver!

> I know, but it was made static in soc-dapm.c when it was renamed to
> snd_soc_dapm_set_pin.

In cases like this you should submit a patch adding the API back to the
core rather than adding a generic API as local code in your machine

More information about the Alsa-devel mailing list