[alsa-devel] [Pull request] Support for wm9705 codec and two machines that use it.

Mark Brown broonie at sirena.org.uk
Thu Jan 15 18:20:58 CET 2009

On Thu, Jan 15, 2009 at 10:06:53AM +0000, Ian Molton wrote:
> Takashi Iwai wrote:

> > We need reviews.  Could you post patches as well?

> Sure - attached below:

Always do this for ALSA patch submissions (the same thing will apply to
the majority of kernel subsystems).  Please also CC at least me on ASoC
patches.  I do read the list but it helps to make sure things don't get

These all look fine apart from one small thing in the codec driver and
the issue Russell already pointed out.

> +
> +	soc_ac97_ops.reset(codec->ac97);

This should check the return value, resets can and do fail.

More information about the Alsa-devel mailing list