[alsa-devel] [PATCH] sscape: drop redundant fields from soundscape struct

krzysztof.h1 at poczta.fm krzysztof.h1 at poczta.fm
Mon Feb 2 09:20:11 CET 2009

Takashi Iwai napisał(a):
> At Sun, 1 Feb 2009 21:12:31 +0100,
> Krzysztof Helt wrote:
> > 
> > The midi_vol is set only to 0 so it does not work
> > as detection of change in midi volume. It is removed.
> It's used to cache the value.  You should better to keep it, but fix
> sscape_midi_put() function to remember the last
> uctl->value.integer.value[0] value in this field.

I know that it was supposed to cache the volume value, but is it really needed?
It is not something time critical and the less code the better.

> (And also better to change sscape_midi_get() to return midi_vol
>  value.)


Doladuj telefon! 
Sprawdz >> http://link.interia.pl/f2047

More information about the Alsa-devel mailing list