[alsa-devel] [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix

Mark Brown broonie at sirena.org.uk
Wed Nov 12 16:25:50 CET 2008

On Wed, Nov 12, 2008 at 04:16:08PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > The global variable is used to tell the DMA driver how to set the
> > hardware up for the port.  Since the variable is tied to the underlying
> > hardware channel it's used for there's no real win from duplicating it
> > into a variable - the hardware it is used to configure can't be shared.

> I know it, but it's still uncomfortable that such secret mythes and
> legends are underlying without explanation.  Could you add some more
> comments around that code to avoid misunderstanding by readers?

Hrm, that's a fairly standard idiom for ASoC DMA/DAI driver interaction
so probably more of a Documentation/ thing but doing it there is not too
helpful for addressing your concern.  I'll have a think.

More information about the Alsa-devel mailing list