[alsa-devel] [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix

Takashi Iwai tiwai at suse.de
Wed Nov 12 16:16:08 CET 2008

At Wed, 12 Nov 2008 15:10:38 +0000,
Mark Brown wrote:
> On Wed, Nov 12, 2008 at 01:33:34PM +0100, Takashi Iwai wrote:
> > I still feel a bit uncomfortable with this as it changes the global
> > variables.  Maybe better to assign the corresponding fields in the
> > local struct.
> The global variable is used to tell the DMA driver how to set the
> hardware up for the port.  Since the variable is tied to the underlying
> hardware channel it's used for there's no real win from duplicating it
> into a variable - the hardware it is used to configure can't be shared.

I know it, but it's still uncomfortable that such secret mythes and
legends are underlying without explanation.  Could you add some more
comments around that code to avoid misunderstanding by readers?



More information about the Alsa-devel mailing list