[alsa-devel] [PATCH] [ML403-AC97CR] Remove duplicate snd_card_set_dev().

Joachim Foerster mls.JOFT at gmx.de
Sat Mar 15 10:43:09 CET 2008

Hi Takashi,

I noticed, that there was a change in ml403-ac97cr.c, which introduces a
second call of snd_card_set_dev() in the _probe()-function. The
"original" one is in the snd_ml403_ac97cr_create()-function.

According the other changes, I guess, we want to have it in the
_probe()-function, now (=> following patch)?

From: Joachim Foerster <JOFT at gmx.de>

We want to have snd_card_set_dev() in _probe(), but not a second one in

Signed-off-by: Joachim Foerster <JOFT at gmx.de>
 sound/drivers/ml403-ac97cr.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 05a871a..b654007 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -1191,8 +1191,6 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev,
 		return err;
-	snd_card_set_dev(card, &pfdev->dev);
 	*rml403_ac97cr = ml403_ac97cr;
 	return 0;

More information about the Alsa-devel mailing list