[alsa-devel] [PATCH] wss_lib: snd_wss_calibrate_mute improvement
rene.herman at keyaccess.nl
Mon Aug 18 13:04:16 CEST 2008
On 18-08-08 12:16, Takashi Iwai wrote:
> At Mon, 18 Aug 2008 10:50:15 +0200,
> Rene Herman wrote:
>> On 17-08-08 22:38, Krzysztof Helt wrote:
>>> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
>>> Mute sound by setting mute bit without
>>> setting volume to 0. It makes both source code
>>> and binary shorter.
>>> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
>> Grmmbbled-over-by: Rene Herman <rene.herman at gmail.com>
>> This should be safe and the current function indeed generates crap code
>> but in the sense of always expecting the worst broken hardware variants
>> to be out there I must say I'd rather have seen that GCC were beter. But
>> yes, sure.
> Yeah, the slightest concern is the intention of using 0x80 there.
Yes, shared that same concern but it's very likely not significant. The
original thought may just have been that you have to write _something_
so you might as well simply write 0x80 instead or or-ing in a bit and
with volume at 0, your're even "doubly safe"...
> If this patch was already tested on some real hardwares (and I guess
> it should work), I'm willing to apply it. Krzystof, was this tested
> on your machines?
Not (yet) on any of mine at least but actually having something where it
does not work would be surprising. I could sort of imagine something
being out there that ignores the mute bit but I doubt that either of us
is actually going to have it even if it is.
Avoiding cargo-cult programming isn't unimportant so let's not be _too_
cautious I guess. It does currently make for crap code (GCC could be
using cmov here it seems but it doesn't) which is an excuse...
More information about the Alsa-devel