[alsa-devel] [PATCH] wss_lib: snd_wss_calibrate_mute improvement
tiwai at suse.de
Mon Aug 18 12:16:02 CEST 2008
At Mon, 18 Aug 2008 10:50:15 +0200,
Rene Herman wrote:
> On 17-08-08 22:38, Krzysztof Helt wrote:
> > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > Mute sound by setting mute bit without
> > setting volume to 0. It makes both source code
> > and binary shorter.
> > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> Grmmbbled-over-by: Rene Herman <rene.herman at gmail.com>
> This should be safe and the current function indeed generates crap code
> but in the sense of always expecting the worst broken hardware variants
> to be out there I must say I'd rather have seen that GCC were beter. But
> yes, sure.
Yeah, the slightest concern is the intention of using 0x80 there.
If this patch was already tested on some real hardwares (and I guess
it should work), I'm willing to apply it. Krzystof, was this tested
on your machines?
More information about the Alsa-devel