[alsa-devel] [PATCH] snd_usb_caiaq: fix potential lockups locking

Daniel Mack daniel at caiaq.org
Thu Apr 3 13:29:21 CEST 2008


attached is a patch for snd_usb_caiaq which fixes system potential 
lockups when stoping and restarting the stream very quickly multiple
times in a row which is what some players do when the user drags the
song position slider.

Also, it seems that snd_pcm_period_elapsed() must not be called when
holding a spinlock? The documentation[*], however, doesn't state that.

As this fixes an annoying bug, I would appreciate seeing that one being
pushed into 2.6.25. Still possible?

Thanks and best regards,

[*] http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/x773.htm#PCM-INTERFACE-INTERRUPT-HANDLER-BOTH


Subject: [PATCH] snd_usb_caiaq: fix potential lockups

This patch fixes potential lockups in snd_usb_caiaq by refining the
locking mechanims and by using usb_kill_urb() in favor to

Signed-off-by: Daniel Mack <daniel at caiaq.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: snd-caiaq-1.3.4.diff
Type: text/x-diff
Size: 8351 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20080403/0ee3ddb8/attachment.bin 

More information about the Alsa-devel mailing list