[alsa-devel] [PATCH 4/4] alsa-driver: schedule_timeout() fixes.

Takashi Iwai tiwai at suse.de
Tue Sep 18 18:44:02 CEST 2007


At Tue, 18 Sep 2007 16:34:46 +0200,
Rene Herman wrote:
> 
> On 09/18/2007 01:54 PM, Takashi Iwai wrote:
> 
> > The other changes look good to me.  But, honestly, I couldn't follow all
> > the pathes you sent in the right order.  So, could you guys make a series
> > of patches to be applied to HG tree?  That'll be really helpful for
> > review, too.
> 
> Two more for alsa-drivers. Just for completeness, but feel free to drop on 
> the floor as well. I'm not hugely sure about that "if (!signal_pending)" in 
> the msnd_pinnacle one (so just keep it interruptible) and the other two are 
> just replacinging HZ calculations.
> 
> Speaking about that msnd one -- I believe I've seen that driver sitting in 
> isa/ in alsa-drivers ages ago already. Is someone still working on that? 
> (no, I don't have the hardware).
> 
> Signed-off-by: Rene Herman <rene.herman at gmail.com>

Got a compiler error.

alsa-driver/isa/msnd/msnd_pinnacle.c: In function ‘snd_msnd_calibrate_adc’:
alsa-driver/isa/msnd/msnd_pinnacle.c:692: error: implicit declaration of function ‘msecs_to_jiffiies’


Takashi


More information about the Alsa-devel mailing list