[alsa-devel] [PATCH 4/4] alsa-driver: schedule_timeout() fixes.

[Rene Herman]

On 09/18/2007 06:44 PM, Takashi Iwai wrote:

>> Speaking about that msnd one -- I believe I've seen that driver sitting in 
>> isa/ in alsa-drivers ages ago already. Is someone still working on that? 
>> (no, I don't have the hardware).
>>
>> Signed-off-by: Rene Herman <rene.herman at gmail.com>
> 
> Got a compiler error.
> 
> alsa-driver/isa/msnd/msnd_pinnacle.c: In function ‘snd_msnd_calibrate_adc’:
> alsa-driver/isa/msnd/msnd_pinnacle.c:692: error: implicit declaration of function ‘msecs_to_jiffiies’

What an amazingly perfect example of the problem with noisy builds ;-/

For me, it's a warning, buried just above a string of other warnings:

   CC [M]  /home/rene/src/alsa/alsa-driver/isa/msnd/msnd.o
   CC [M]  /home/rene/src/alsa/alsa-driver/isa/msnd/msnd_pinnacle.o
/home/rene/src/alsa/alsa-driver/isa/msnd/msnd_pinnacle.c: In function 
'snd_msnd_calibrate_adc':
/home/rene/src/alsa/alsa-driver/isa/msnd/msnd_pinnacle.c:692: warning: 
implicit declaration of function 'msecs_to_jiffiies'
include/asm/io.h: In function 'memcpy_toio':
include/asm/io.h:208: warning: passing argument 1 of '__memcpy' discards 
qualifiers from pointer target type
include/asm/io.h: In function 'memset_io':
include/asm/io.h:200: warning: passing argument 1 of 
'__constant_c_and_count_memset' discards qualifiers from pointer target type
include/asm/io.h:200: warning: passing argument 1 of '__constant_c_memset' 
discards qualifiers from pointer target type
include/asm/io.h:200: warning: passing argument 1 of '__memset_generic' 
discards qualifiers from pointer target type
include/asm/io.h:200: warning: passing argument 1 of '__memset_generic' 
discards qualifiers from pointer target type
   CC [M]  /home/rene/src/alsa/alsa-driver/isa/msnd/msnd_pinnacle_mixer.o
   CC [M]  /home/rene/src/alsa/alsa-driver/isa/msnd/msnd_midi.o
   LD [M]  /home/rene/src/alsa/alsa-driver/isa/msnd/snd-msnd-pinnacle.o
   CC [M]  /home/rene/src/alsa/alsa-driver/isa/opti9xx/miro.o

(and I'm still getting used to this mercurial environment and just building 
everything with ./hgcompile meaning it's a lot of output).

Anyways, s/jiffiies/jiffies/ and sorry for not noticing. Updated patch 
attached. Changelog:

===
alsa-driver: use schedule_timeout_{,un}interruptible.

Replace 3 open-coded implementations of schedule_timout_{,un}interruptible 
and use {u,m}secs_to_jiffies.

Signed-off-by: Rene Herman <rene.herman at gmail.com>
===

Rene.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: schedule_timeout-alsa_driver.diff
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20070918/cc1d859e/attachment-0001.bat