[alsa-devel] [PATCH 3/4] alsa-kernel: schedule_timeout() fix for core/seq/seq_instr.c

[Rene Herman]

On 09/18/2007 03:57 PM, Rene Herman wrote:

Subject was supposed to be as above.

> Well, if you insist, but thought I'd submit is seperately once again. 
> The schedule_timeout() calls in there are so-so, will simply not 
> schedule, but that
> 
>     while (instr->use)
>         schedule_timeout(1);
> 
> loop is dangerous. There's nothing that I can see that's stopping the 
> compiler from turning this into an infinite loop:
> 
>     if (instr->use)
>         while (1)
>             schedule_timeout(1);
> 
> I'll admit I have no idea where this code ends up, but if it's _ever_ 
> used this seems to not be good.
> 
> Ofcourse, feel free to drop on the floor if you really do insist.
> 
> Signed-off-by: Rene Herman <rene.herman at gmail.com>

Rene.