[alsa-devel] [PATCH] ad1838/cs4231 -- fix MCE timeout upon initial load

Rene Herman rene.herman at gmail.com
Tue Sep 18 15:57:41 CEST 2007

On 09/18/2007 01:54 PM, Takashi Iwai wrote:

> Let's leave seq_instr as is.  It's a never-working concept.  The only
> user is OPL3, and this should be rewritten using hwdep.  Then we'll
> get rid of this whole code chunk.

Well, if you insist, but thought I'd submit is seperately once again. The 
schedule_timeout() calls in there are so-so, will simply not schedule, but that

	while (instr->use)

loop is dangerous. There's nothing that I can see that's stopping the 
compiler from turning this into an infinite loop:

	if (instr->use)
		while (1)

I'll admit I have no idea where this code ends up, but if it's _ever_ used 
this seems to not be good.

Ofcourse, feel free to drop on the floor if you really do insist.

Signed-off-by: Rene Herman <rene.herman at gmail.com>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: schedule_timeout-seq_instr.diff
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20070918/d7761058/attachment.bat 

More information about the Alsa-devel mailing list