[alsa-devel] [PATCH] sound/isa: kill pnp_resource_change.

Takashi Iwai tiwai at suse.de
Thu Nov 29 15:07:56 CET 2007

At Thu, 29 Nov 2007 02:10:33 +0100,
Rene Herman wrote:
> Hi Takashi.
> This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
> 2.4 these were useful in providing an easy path to setting the resources,
> but in 2.6 they retain function as a layering violation only.
> This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
> only remaining user of pnp_init_resource_table(), pnp_resource_change() and
> pnp_manual_config_dev() (and, in fact, of "struct pnp_resource_table") in
> the tree outide of drivers/pnp itself meaning it makes for more cleanup
> potential inside the PnP layer.
> Thomas Renninger acked their removal from that side, you did from the ALSA
> side (CC list just copied from that thread).
> Against current alsa-kernel HG. Many more potential cleanups in there, but 
> this _only_ removes the pnp_resource_change code. Compile tested against 
> current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few 
> offsets).
> Signed-off-by: Rene Herman <rene.herman at gmail.com>

A good work.  I'll merge this tomorrow to ALSA tree if no one raises
objection now.



More information about the Alsa-devel mailing list