[alsa-devel] [PATCH] sound/isa: kill pnp_resource_change.

Rene Herman rene.herman at gmail.com
Thu Nov 29 02:10:33 CET 2007


Hi Takashi.

This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
2.4 these were useful in providing an easy path to setting the resources,
but in 2.6 they retain function as a layering violation only.

This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
only remaining user of pnp_init_resource_table(), pnp_resource_change() and
pnp_manual_config_dev() (and, in fact, of "struct pnp_resource_table") in
the tree outide of drivers/pnp itself meaning it makes for more cleanup
potential inside the PnP layer.

Thomas Renninger acked their removal from that side, you did from the ALSA
side (CC list just copied from that thread).

Against current alsa-kernel HG. Many more potential cleanups in there, but 
this _only_ removes the pnp_resource_change code. Compile tested against 
current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few 
offsets).

Signed-off-by: Rene Herman <rene.herman at gmail.com>

  Documentation/ALSA-Configuration.txt |   35 ------------
  isa/ad1816a/ad1816a.c                |   55 ++-----------------
  isa/als100.c                         |   49 ----------------
  isa/azt2320.c                        |   50 -----------------
  isa/cmi8330.c                        |   42 +-------------
  isa/cs423x/cs4236.c                  |  101 
+++++++----------------------------
  isa/dt019x.c                         |   48 +---------------
  isa/es18xx.c                         |   58 +++-----------------
  isa/gus/interwave.c                  |   39 +------------
  isa/opl3sa2.c                        |   36 ------------
  isa/opti9xx/opti92x-ad1848.c         |   50 +----------------
  isa/sb/es968.c                       |   27 ---------
  isa/sb/sb16.c                        |   39 -------------
  isa/wavefront/wavefront.c            |   55 +------------------
  14 files changed, 65 insertions(+), 619 deletions(-)



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: alsa-kernel_pnp_resource_change.diff
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20071129/56e630b6/attachment-0001.bat 


More information about the Alsa-devel mailing list