[alsa-devel] [PATCH] Disable debugging output for the ALS300 driver

Takashi Iwai tiwai at suse.de
Tue May 29 16:28:00 CEST 2007

At Tue, 29 May 2007 09:09:39 -0500,
Ash Willis wrote:
> > Also I changed "if ((err = ...))" to two individual lines, which is a
> > newer standard kernel coding style.
> > 
> Yeah, I left that for now. I'll go through the tree and tidy up remaining
> occurences of this style when I have some time.

Note that I didn't rewrite the existing lines but just changes in the
patch.  It'll be appreciated if you send a patch to clean up these
things in your driver.

> It seems that when people add drivers to the tree, they generally copy
> already existing drivers. It doesn't make much sense to be copying code
> that doesn't fit CodingStyle.

Right.  A general clean up work is appreciated.



More information about the Alsa-devel mailing list