[alsa-devel] [PATCH] Disable debugging output for the ALS300 driver
ashwillis at programmer.net
Tue May 29 16:09:39 CEST 2007
> ----- Original Message -----
> From: "Takashi Iwai" <tiwai at suse.de>
> To: "Ash Willis" <ashwillis at programmer.net>
> Subject: Re: [alsa-devel] [PATCH] Disable debugging output for the ALS300 driver
> Date: Tue, 29 May 2007 15:08:30 +0200
> At Sat, 26 May 2007 13:26:35 +0000,
> Ash Willis wrote:
> > Disables debugging output in the ALS300 driver.
> > Also contains a whitespace cleanup and a fix for a potential bug.
> > Signed-off-by: Ash Willis <ashwillis at programmer.net>
> Thanks for the patch. It seems that your MUA breaks the embedded
> patch, so I had to apply it manually. Could you check whether the
> latest HG is OK for you?
I'm away from home right now. I'll test it as soon as I have a chance
but it looks fine.
> Also I changed "if ((err = ...))" to two individual lines, which is a
> newer standard kernel coding style.
Yeah, I left that for now. I'll go through the tree and tidy up remaining
occurences of this style when I have some time.
It seems that when people add drivers to the tree, they generally copy
already existing drivers. It doesn't make much sense to be copying code
that doesn't fit CodingStyle.
Sports Memorabilia License Plates Signs
All license plates $6 all signs $10 all frames $8 - same day shipping - fun company and selection.
More information about the Alsa-devel