[alsa-devel] [Alsa-devel] Quality resampling code for libasound

Jean-Marc Valin jean-marc.valin at usherbrooke.ca
Wed Mar 21 14:08:09 CET 2007


> OK, as long as it's in alsa-plugins repository, I basically don't
> care.  But, for merging it to alsa-lib, I'd like to change the code
> very much (including coding-style unification).

Well, it's ultimately your call. For rate_speexrate.c, it really doesn't
matter what happens because that's the only place it's used. When it
comes to the resampler code itself, it depends on how you want to
maintain it. I'll be maintaining it from the Speex tree, so it you want
to change the style, you'll have to either "backport" improvements/fixes
(e.g. optimisations) or do the style change again every time you sync.
That is, unless you plan to do an alsa-specific fork of it. (I
personally think the simplest way would be not modify the core resampler
(resample.c and corresponding header files) and just sync with Speex
once in a while.

> Anyway, I applied your latest codes to HG tree now (with the removal
> of samplerate.h).  Thanks!

Thanks.

	Jean-Marc


More information about the Alsa-devel mailing list