[Sound-open-firmware] Commits in SOF

Daniel Baluta daniel.baluta at gmail.com
Wed May 29 15:50:10 CEST 2019


<snip>

> Personally I capitalise the subject line only if it doesn't contain
> any prefixes, e.g.
>
> 37624b5 Linux 5.1-rc7
>
> or
>
> b2a20fd Merge branch 'bnxt_en-Misc-bug-fixes'
>
> etc. I.e. really only special cases. When there are prefixes I
> personally optically prefer
>
> 8118b82 mm/page_alloc.c: fix never set ALLOC_NOFRAGMENT flag
>
> to
>
> ef61eb4 USB: yurex: Fix protection fault after device removal
>
> As far as I know in English a colon should be followed by lower
> case, it's in German that it is followed by upper case. So, I
> would appreciate it if we didn't try to enforce this, at least
> not until there's a corresponding entry in CodingStyle ;-) We
> also could collect some statistics. E.g. of the last 5000 commits
> in my current Linux tree, that contain a colon in the subject,
>  2692 begin with a lower case after the last colon and 1825 with
> upper case.

I see your point on this and I agree!
No enforcement for capital letter after prefix strings.

Anyhow, I am stressing again on writing good commit
messages which explain WHY the change is needed.

thanks,
Daniel.


More information about the Sound-open-firmware mailing list