[Sound-open-firmware] checkpatch.pl fixes
Daniel Baluta
daniel.baluta at gmail.com
Mon Mar 4 14:48:06 CET 2019
On Mon, Mar 4, 2019 at 2:50 PM Seppo Ingalsuo
<seppo.ingalsuo at linux.intel.com> wrote:
>
>
> On 4.3.2019 14.24, Daniel Baluta wrote:
> > Hi all,
> >
> > What is your take on checkpatch.pl fixes for SOF FW?
> >
> > Diana (CC'ed) is trying to get accustomed with SOF code
> > and while at that she can fix some obvious checkpatch.pl
> > warn / errors.
> >
> > Does it make sense to send some patches for that?
> >
> > I know that this kind of fixes can pollute the change
> > history but on the other side code gets a little bit cleaner.
>
>
> Sounds good, my +1 for cleanup!
Thanks Seppo, we will have a look if no strong option against.
Btw, I noticed that the pre/post commit hooks that enforce checkpatch.pl
have been removed from SOF tree. Any idea why?
thanks,
Daniel.
More information about the Sound-open-firmware
mailing list