[Sound-open-firmware] can stream-box size be 0?

[Keyon Jie]

On 2019/4/3 下午9:33, Guennadi Liakhovetski wrote:
> Hi,
> 
> In kernel ipc.c I see "if (sdev->stream_box.size == 0)" checks at
> exactly 4 locations, but all currently supported by SOF platforms set
> the size to 0x200. Do we need those checks or can we safely assume, that
> the size is never 0?

I think before Xiuli implemented this stream-box(use for stream specific 
information sharing b/w FW/driver, e.g. position update), this 
stream_box.size was always 0(stream position was located in dsp-box in 
this scenario), we added those checks for compatibility purpose on 
driver side.

I think better to keep checking, but it would be good if we can simplify 
the checking in ipc_period_elapsed() and ipc_xrun(), e.g. only check 
once in each function.

Thanks,
~Keyon

> 
> Thanks
> Guennadi
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
>