[Sound-open-firmware] [PATCH 01/15] [RFC][v2]DMIC: Add PDM microphones (DMIC) support to DAI

[Liam Girdwood]

On Fri, 2018-05-11 at 13:47 +0300, Seppo Ingalsuo wrote:
> On 07.05.2018 14:37, Liam Girdwood wrote:
> > > +	if (direction != DAI_DIR_CAPTURE) {
> > > +		trace_dmic_error("cap");
> > > +		return -EINVAL;
> > > +	}
> > 
> > You need to do this here :-
> > 
> > 	ret = comp_set_state(dev, cmd);
> > 	if (ret < 0)
> > 		return ret;
> > 
> > This does all state checking/setting so no need to do it below.
> > 
> 
> I tried but I noticed it can't be done since struct comp_dev *dev and 
> struct dmic_pdata *dmic are not the same.
> 
> 

Ah, yes you are right, I was thinking this was a component. Please resend it as
part of your next series.

Liam