[Sound-open-firmware] [PATCH] SOFT: Add SA, DMIC and SCH trace class definition.

[Pierre-Louis Bossart]

On 5/10/18 6:42 AM, sound-open-firmware-bounces at alsa-project.org wrote:
> From: Yan Wang <yan.wang at linux.intel.com>
> 
> There are 3 new trace classes in SOF.
> So rmbox need also add them for displaying trace.
> 
> Signed-off-by: Yan Wang <yan.wang at linux.intel.com>
> ---
> Test with:
> CNL nocodec
> SOF master: c1f2682c210201bbbc96fce7b382b25b90d19775
> SOF-Tool master: 86fe688a2b4f68a1ce87e0951686be12a00f1a3c
> https://github.com/plbossart/sound/tree/topic/sof-v4.14:
> d09db67c5a9d6dfc85f700669fa2e43c678c8d51
> ---
>   rmbox/rmbox.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/rmbox/rmbox.c b/rmbox/rmbox.c
> index 4df2ee1..2d1f512 100644
> --- a/rmbox/rmbox.c
> +++ b/rmbox/rmbox.c
> @@ -46,6 +46,9 @@
>   #define TRACE_CLASS_TONE        (18 << 24)
>   #define TRACE_CLASS_EQ_FIR      (19 << 24)
>   #define TRACE_CLASS_EQ_IIR      (20 << 24)
> +#define TRACE_CLASS_SA          (21 << 24)
> +#define TRACE_CLASS_DMIC        (22 << 24)
> +#define TRACE_CLASS_SCH         (23 << 24)
>   
>   #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))
>   
> @@ -162,6 +165,12 @@ static void show_trace(uint64_t val, uint64_t addr, uint64_t *timestamp, double
>   		trace = "eq-fir";
>   	else if (class == TRACE_CLASS_EQ_IIR)
>   		trace = "eq-iir";
> +	else if (class == TRACE_CLASS_SA)
> +		trace = "sa";
> +	else if (class == TRACE_CLASS_DMIC)
> +		trace = "dmic";
> +	else if (class == TRACE_CLASS_SCH)
> +		trace = "sch";

Can we not get all these definitions and strings from a header instead 
of duplicating information that is already in multiple places?

>   	else {
>   		printf("value 0x%8.8x\n", (uint32_t)val);
>   		return;
>