[Sound-open-firmware] [PATCH 06/15] [RFC][v2]DMIC: Add SOF DMIC trace definitions

[yanwang]

On Mon, 2018-05-07 at 17:16 +0300, Seppo Ingalsuo wrote:
> 
> On 07.05.2018 14:20, Liam Girdwood wrote:
> > 
> > On Fri, 2018-05-04 at 18:01 +0300, Seppo Ingalsuo wrote:
> > > 
> > > Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo at linux.intel.com>
> > > ---
> > >   src/include/sof/trace.h | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/src/include/sof/trace.h b/src/include/sof/trace.h
> > > index 5409a1f..2fd77fe 100644
> > > --- a/src/include/sof/trace.h
> > > +++ b/src/include/sof/trace.h
> > > @@ -71,7 +71,7 @@
> > >   #define TRACE_BOOT_PLATFORM_IPC		(TRACE_BOOT_PLAT
> > > FORM + 0x170)
> > >   #define TRACE_BOOT_PLATFORM_DMA		(TRACE_BOOT_PLAT
> > > FORM + 0x180)
> > >   #define TRACE_BOOT_PLATFORM_SSP		(TRACE_BOOT_PLAT
> > > FORM + 0x190)
> > > -
> > > +#define TRACE_BOOT_PLATFORM_DMIC	(TRACE_BOOT_PLATFORM +
> > > 0x1a0)
> > >   
> > >   /* trace event classes - high 8 bits*/
> > >   #define TRACE_CLASS_IRQ		(1 << 24)
> > > @@ -95,6 +95,7 @@
> > >   #define TRACE_CLASS_EQ_FIR      (19 << 24)
> > >   #define TRACE_CLASS_EQ_IIR      (20 << 24)
> > >   #define TRACE_CLASS_SA		(21 << 24)
> > > +#define TRACE_CLASS_DMIC	(22 << 24)
> > >   
> > oh, we should really export trace types to a uapi header (trace.h
> > ?) that rmbox
> > can include.
> 
> Should I do a generic patch for all TRACE_CLASS first (without DMIC 
> stuff)? And should the TRACE_BOOT definitions be there too?

I am seperating trace into global, comp_dev, comp_buffer and piepeline
trace. Could it be changed after trace level patch set merged?
Thanks.

Yan Wang

> 
> Thanks,
> Seppo
> 
> > 
> > 
> > Liam
> > 
> > _______________________________________________
> > Sound-open-firmware mailing list
> > Sound-open-firmware at alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmwar
> > e
> > 
> 
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware