[Sound-open-firmware] [PATCH] sof: Add volume component state check

zhigang.wu zhigang.wu at linux.intel.com
Tue Mar 27 11:39:01 CEST 2018



On 2018年03月27日 17:31, Liam Girdwood wrote:
> On Tue, 2018-03-27 at 09:42 +0800, Wu Zhigang wrote:
>> Add the state check in volume_copy function,
>> this can low down the xrun error possibility:
>> For example:
>> when firmware receive the PAUSE command, the HOST and VOLUME
>> component are set to PAUSE state. at this time DMA IRQ happen,
>> the pipeline is scheduled. host_copy() function will be called,
>> but jump out immediately because of PAUSE state. but volume_copy()
>> did not have this state check, the xrun will happen.
>>
>> Signed-off-by: Wu Zhigang <zhigang.wu at linux.intel.com>
>> Reviewed-by: Keyon Jie <yang.jie at linux.intel.com>
>>
>>
> This is no longer needed since we fixed the locking in your latest patch.
>
> Liam
yes, you are right!

> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware



More information about the Sound-open-firmware mailing list